Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754663AbdGJRC2 (ORCPT ); Mon, 10 Jul 2017 13:02:28 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35589 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319AbdGJRCZ (ORCPT ); Mon, 10 Jul 2017 13:02:25 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] brcmfmac: added LED triggers for transmit/receive From: Russell Joyce In-Reply-To: Date: Mon, 10 Jul 2017 18:02:21 +0100 Cc: Alan Millard , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Marc Kleine-Budde , Marcel Holtmann , "Michael S. Tsirkin" , Pieter-Paul Giesberts , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , "mhiramat@kernel.org" , James Hughes , Tobias Klauser , Linux Kernel Mailing List , "linux-wireless@vger.kernel.org" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , brcm80211-dev-list@cypress.com, Network Development Message-Id: References: <20170707140941.122115-1-russell.joyce@york.ac.uk> To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6AH2cul002105 Content-Length: 1131 Lines: 26 > 1) I think most of it should be some cfg80211 shareable code. I’m not sure exactly what you mean by this, could you please clarify? > 2) This "rxtx" while surely present in other places sounds like a > workaround for LED subsystem limitation. Maybe it's time to finally > rework LED triggers. I agree that it’s not an ideal way to do things, but I couldn’t think of a better alternative. I think that having a combined trigger is useful though, for situations like using the single LED on a Raspberry Pi to show Wi-Fi activity. > On 10 Jul 2017, at 10:48, Rafał Miłecki wrote: > > On 7 July 2017 at 16:09, Russell Joyce wrote: >> Add three basic LED triggers to brcmfmac, based on those in mac80211: one >> for transmit, one for receive, and one for combined transmit/receive. >> >> Signed-off-by: Russell Joyce > > 1) I think most of it should be some cfg80211 shareable code. > 2) This "rxtx" while surely present in other places sounds like a > workaround for LED subsystem limitation. Maybe it's time to finally > rework LED triggers.