Date: Mon, 10 Jul 2017 10:27:05 -0700
From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Aubrey Li <aubrey.li@intel.com>, tglx@linutronix.de,
        len.brown@intel.com, rjw@rjwysocki.net, tim.c.chen@linux.intel.com,
        arjan@linux.intel.com, paulmck@linux.vnet.ibm.com,
        yang.zhang.wz@gmail.com, x86@kernel.org, linux-kernel@vger.kernel.org,
        Aubrey Li <aubrey.li@linux.intel.com>
Subject: Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods
Message-ID: <20170710172705.GA3441@tassilo.jf.intel.com>
References: <1499650721-5928-1-git-send-email-aubrey.li@intel.com>
 <20170710084647.zs6wkl3fumszd33g@hirez.programming.kicks-ass.net>
 <20170710144609.GD31832@tassilo.jf.intel.com>
 <20170710164206.5aon5kelbisxqyxq@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170710164206.5aon5kelbisxqyxq@hirez.programming.kicks-ass.net>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 25

On Mon, Jul 10, 2017 at 06:42:06PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 10, 2017 at 07:46:09AM -0700, Andi Kleen wrote:
> > > So how much of the gain is simply due to skipping NOHZ? Mike used to
> > > carry a patch that would throttle NOHZ. And that is a _far_ smaller and
> > > simpler patch to do.
> > 
> > Have you ever looked at a ftrace or PT trace of the idle entry?
> > 
> > There's just too much stuff going on there. NOHZ is just the tip
> > of the iceberg.
> 
> I have, and last time I did the actual poking at the LAPIC (to make NOHZ
> happen) was by far the slowest thing happening.

That must have been a long time ago because modern systems use TSC deadline
for a very long time ...  

It's still slow, but not as slow as the LAPIC.

> Data to indicate what hurts how much would be a very good addition to
> the Changelogs. Clearly you have some, you really should have shared.

Aubrey?

-Andi