Date: Mon, 10 Jul 2017 19:34:39 +0100 (WEST)
Message-Id: <20170710.193439.1383814646174599742.davem@davemloft.net>
To: arnd@arndb.de
Cc: saeedm@mellanox.com, ilant@mellanox.com, matanb@mellanox.com,
        leonro@mellanox.com, yossiku@mellanox.com, kliteyn@mellanox.com,
        borisp@mellanox.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170710093842.2921914-1-arnd@arndb.de>
References: <20170710093842.2921914-1-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 748
Lines: 19

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Jul 2017 11:37:51 +0200

> The new IPSec offload code introduced a build error:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.o: In function `mlx5e_ipsec_build_inverse_table':
> ipsec_rxtx.c:(.text+0x556): undefined reference
> 
> Another patch was added on top to fix the build error, but
> that introduced a new bug, as we now use the remainder of
> the division rather than the result.
> 
> This makes it use the correct helper function instead.
> 
> Fixes: 5dfd87b67cd9 ("net/mlx5: IPSec, Fix 64-bit division on 32-bit builds")
> Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data path")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.