Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbdGJTEz (ORCPT ); Mon, 10 Jul 2017 15:04:55 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:35244 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbdGJTEx (ORCPT ); Mon, 10 Jul 2017 15:04:53 -0400 Date: Mon, 10 Jul 2017 15:04:52 -0400 From: Sean Paul To: Mark yao Cc: "Gustavo A. R. Silva" , David Airlie , Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value Message-ID: <20170710190452.6nzd4tihronl5m5n@art_vandelay> References: <20170706215833.GA25411@embeddedgus> <595EDC3C.1010801@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <595EDC3C.1010801@rock-chips.com> User-Agent: NeoMutt/20170306-66-6ddb52-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 60 On Fri, Jul 07, 2017 at 08:56:28AM +0800, Mark yao wrote: > On 2017年07月07日 05:58, Gustavo A. R. Silva wrote: > > The right variable to check here is port, not dp. > > > > This issue was detected using Coccinelle and the following semantic patch: > > > > @@ > > expression x; > > identifier fld; > > @@ > > > > * x = devm_kzalloc(...); > > ... when != x == NULL > > x->fld > > > > Signed-off-by: Gustavo A. R. Silva > > Thanks for the fix, > > Acked-by: Mark Yao Hi Mark, I've applied this patch, but in the future, please apply changes directly instead of just acking. If you're unable to apply it for some reason (vacation, etc), please reach out to one of the -misc maintainers via email or irc so we don't inadvertently lose track of it on the list. Sean > > > --- > > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > > index 14fa1f8..9b0b058 100644 > > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > > @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev) > > continue; > > port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL); > > - if (!dp) > > + if (!port) > > return -ENOMEM; > > port->extcon = extcon; > > > -- > Ｍark Yao > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS