Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294AbdGJTfH (ORCPT ); Mon, 10 Jul 2017 15:35:07 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.12]:16348 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbdGJTfG (ORCPT ); Mon, 10 Jul 2017 15:35:06 -0400 Date: Mon, 10 Jul 2017 14:35:03 -0500 Message-ID: <20170710143503.Horde.9_zvXVtnaguZVZiamVnhJh4@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Evgeniy Polyakov Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] w1: omap-hdq: fix error return code in omap_hdq_probe() References: <20170630224402.GA22776@embeddedgus> <865431499441939@web32j.yandex.ru> In-Reply-To: <865431499441939@web32j.yandex.ru> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dUeSV-0034xL-K5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:12422 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 31 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 52 Hi Evgeniy, Quoting Evgeniy Polyakov : > Hi Gustavo, Greg > > 01.07.2017, 01:44, "Gustavo A. R. Silva" : >> platform_get_irq() returns an error code, but the omap_hdq >> driver ignores it and always returns -ENXIO. This is not correct, >> and prevents -EPROBE_DEFER from being propagated properly. >> Notice that platform_get_irq() no longer returns 0 on error. >> >> Print error message and propagate the return value of >> platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva > > Looks good to me, thank you. > Glad to help. :) > Greg, please pull it into the tree. > Acked-by: Evgeniy Polyakov > >> --- >>  drivers/w1/masters/omap_hdq.c | 3 ++- >>  1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c >> index 3612542..83fc9aa 100644 >> --- a/drivers/w1/masters/omap_hdq.c >> +++ b/drivers/w1/masters/omap_hdq.c >> @@ -704,7 +704,8 @@ static int omap_hdq_probe(struct platform_device *pdev) >> >>          irq = platform_get_irq(pdev, 0); >>          if (irq < 0) { >> - ret = -ENXIO; >> + dev_dbg(&pdev->dev, "Failed to get IRQ: %d\n", irq); >> + ret = irq; >>                  goto err_irq; >>          } >> >> -- >> 2.5.0 -- Gustavo A. R. Silva