Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754548AbdGJTka (ORCPT ); Mon, 10 Jul 2017 15:40:30 -0400 Received: from gateway36.websitewelcome.com ([192.185.199.121]:36729 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754009AbdGJTk2 (ORCPT ); Mon, 10 Jul 2017 15:40:28 -0400 Date: Mon, 10 Jul 2017 14:40:25 -0500 Message-ID: <20170710144025.Horde.vDNHGoVgk8qoRyi4crvw77O@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Martin Blumenstingl Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Carlo Caione , Kevin Hilman , linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value References: <20170707064630.GA21945@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dUeXi-00399u-3C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:26698 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 40 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1632 Lines: 58 Hi Martin, Quoting Martin Blumenstingl : > On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva > wrote: >> Check return value from call to of_match_device() >> in order to prevent a NULL pointer dereference. >> >> In case of NULL print error message and return -ENODEV >> >> Signed-off-by: Gustavo A. R. Silva > thanks for finding this. a crash here is a rather theoretical problem > (since all compatible strings have their corresponding match data) - > but it doesn't hurt either, so: > I get it, glad to help. :) > Acked-by: Martin Blumenstingl > > >> --- >> drivers/iio/adc/meson_saradc.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >> index 83da50e..07dbcc3 100644 >> --- a/drivers/iio/adc/meson_saradc.c >> +++ b/drivers/iio/adc/meson_saradc.c >> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct >> platform_device *pdev) >> init_completion(&priv->done); >> >> match = of_match_device(meson_sar_adc_of_match, &pdev->dev); >> + if (!match) { >> + dev_err(&pdev->dev, "failed to match device\n"); >> + return -ENODEV; >> + } >> + >> priv->data = match->data; >> >> indio_dev->name = priv->data->name; >> -- >> 2.5.0 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Gustavo A. R. Silva