Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754950AbdGJWZT (ORCPT ); Mon, 10 Jul 2017 18:25:19 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36343 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754657AbdGJWZS (ORCPT ); Mon, 10 Jul 2017 18:25:18 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: References: <20170619213348.2970-1-aranea@aixah.de> <1497989063.12069.18.camel@tycho.nsa.gov> <20170621114812.6aa3f62e@vega.skynet.aixah.de> From: Paul Moore Date: Mon, 10 Jul 2017 18:25:15 -0400 Message-ID: Subject: Re: [PATCH] selinux: Assign proper class to PF_UNIX/SOCK_RAW sockets To: Luis Ressel Cc: Stephen Smalley , James Morris , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1828 Lines: 43 On Wed, Jun 21, 2017 at 3:04 PM, Paul Moore wrote: > On Wed, Jun 21, 2017 at 5:48 AM, Luis Ressel wrote: >> On Tue, 20 Jun 2017 17:43:38 -0400 >> Paul Moore wrote: >> >>> Considering where we are at with respect to the merge window, let's >>> shelve this for now and I'll merge it after the next merge window >>> closes. In all likelihood I'll be sending selinux/next up to James >>> later this week and I'd like this to sit in linux-next for longer than >>> a few days. >> >> That means the change will land in 4.14 at the earliest, right? (Just >> out of curiosity.) > > That's correct. We are currently working towards a v4.12 release in > Linus' tree, the upcoming merge window will be for v4.13, and things > merged into selinux/next after that merge window will be for v4.14. > >> By the way, refpolicy only grants "socket" permissions to a handful of >> domains, all of which also have the corresponding "unix_dgram_socket" >> permissions. The fedora policy does the same (according to Stephen); >> this only leaves custom policies to be potentially affected by this >> change. > > While custom policies are definitely in the minority, we still need to > do out best not to break them without warning. > >> Given that the SOCK_RAW->SOCK_DGRAM translation is obscure enough not to >> be documented anywhere outside the kernel sources, I doubt there are >> many users of it, anyway. > > You very well may be right, I just felt that such a change requires > more than a week in the selinux/next tree. > > Thank you for your patch, it's in the queue and I'll be merging it > into the selinux/next branch in a few weeks. With all of the SELinux things for v4.13 upstream, I went ahead and merged this patch into selinux/next. -- paul moore www.paul-moore.com