Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754949AbdGKBQj (ORCPT ); Mon, 10 Jul 2017 21:16:39 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:36186 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbdGKBQh (ORCPT ); Mon, 10 Jul 2017 21:16:37 -0400 Subject: Re: [PATCH] dma: k3dma: Fix non-cyclic mode To: John Stultz , lkml Cc: Antonio Borneo , Vinod Koul , Dan Williams , dmaengine@vger.kernel.org References: <1499720023-6187-1-git-send-email-john.stultz@linaro.org> From: zhangfei Message-ID: <262406f1-b6e3-fb63-b85b-bc341e0d4b6a@linaro.org> Date: Tue, 11 Jul 2017 09:16:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499720023-6187-1-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 30 On 2017年07月11日 04:53, John Stultz wrote: > From: Antonio Borneo > > Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma: Fix > memory handling in preparation for cyclic mode") broke the > logic around ds_run/ds_done in case of non-cyclic DMA. > > This went unnoticed as the only user of k3dma was the i2s > audio driver, but with a patch set to enable dma on SPI, > the issue cropped up. > > This patch resolves the issue by reverting part of the > problematic commit. > > This patch has been tested to ensure both audio playback and SPI > works fine using DMA and that no memory leak is present. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Zhangfei Gao > Cc: dmaengine@vger.kernel.org > Signed-off-by: Antonio Borneo > [jstultz: Expanded commit message a bit] > Signed-off-by: John Stultz Acked-by: Zhangfei Gao Thanks