Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755079AbdGKBWk (ORCPT ); Mon, 10 Jul 2017 21:22:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46834 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdGKBWi (ORCPT ); Mon, 10 Jul 2017 21:22:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 63DDA61287 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 10 Jul 2017 18:22:36 -0700 From: Stephen Boyd To: Kiran Gunda Cc: gregkh@linuxfoundation.org, Abhijeet Dharmapurikar , Christophe JAILLET , Nicholas Troast , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V2 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Message-ID: <20170711012236.GN22780@codeaurora.org> References: <1499690549-30765-1-git-send-email-kgunda@codeaurora.org> <1499690549-30765-6-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499690549-30765-6-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 590 Lines: 15 On 07/10, Kiran Gunda wrote: > Currently the driver sets the pmic arbiter core interrupt as wakeup capable > irrespective of the child irqs which causes the system to wakeup > unnecessarily. To fix this, set the core interrupt as wakeup capable > only if any of the child irqs request for it. Do this by marking it as > wakeup capable in the irq_set_wake callback. > > Signed-off-by: Kiran Gunda > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project