Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755253AbdGKCIE (ORCPT ); Mon, 10 Jul 2017 22:08:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:46538 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755190AbdGKCIB (ORCPT ); Mon, 10 Jul 2017 22:08:01 -0400 Subject: Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition To: Gleb Fotengauer-Malinovskiy , Greg Kroah-Hartman Cc: Jiri Slaby , Arnd Bergmann , Christian Brauner , Valentin Rothberg , "Dmitry V. Levin" , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org References: <20170711001207.GA11642@glebfm.cloud.tilaa.com> From: Aleksa Sarai Message-ID: Date: Tue, 11 Jul 2017 12:07:43 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170711001207.GA11642@glebfm.cloud.tilaa.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 349 Lines: 13 > This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag > because it doesn't copy anything from/to userspace to access the > argument. Acked-by: Aleksa Sarai Oops, I misunderstood what _IOR means semantically. TIL -- thanks! -- Aleksa Sarai Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/