Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755056AbdGKCbg (ORCPT ); Mon, 10 Jul 2017 22:31:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:34612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdGKCbf (ORCPT ); Mon, 10 Jul 2017 22:31:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46B5022C85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org MIME-Version: 1.0 In-Reply-To: <1499713523-19184-2-git-send-email-frowand.list@gmail.com> References: <1499713523-19184-1-git-send-email-frowand.list@gmail.com> <1499713523-19184-2-git-send-email-frowand.list@gmail.com> From: Rob Herring Date: Mon, 10 Jul 2017 21:31:13 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] of: overlay: add overlay unittest data for node names and symbols To: Frank Rowand Cc: Pantelis Antoniou , Pantelis Antoniou , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2010 Lines: 53 On Mon, Jul 10, 2017 at 2:05 PM, wrote: > From: Frank Rowand > > Add nodes and properties to overlay_base and overlay dts files to > test for > - incorrect existing node name detection when overlay node name > has a unit-address > - adding overlay __symbols__ properties to live tree when an > overlay is added to the live tree > > Expected result from patch 2/3 is overlay will update the nodes and > properties for /testcase-data-2/fairway-1/ride@100/ > > Before patch 2/3 is applied: This is good information, but what is patch 2/3 is less clear when this is committed. And 1 and 2 are probably stable material? I'd just note in this patch what the failures are and show before and after results in the patch that changes them. > Console error message near end of unittest: > OF: Duplicate name in fairway-1, renamed to "ride@100#1" > > $ cd /proc/device-tree/testcase-data-2/fairway-1/ > $ # extra node: ride@100#1 > $ ls > #address-cells linux,phandle phandle ride@200 > #size-cells name ride@100 status > compatible orientation ride@100#1 > $ cd /proc/device-tree/testcase-data-2/fairway-1/ride@100/ > $ ls track@3/incline_up > ls: track@3/incline_up: No such file or directory > $ ls track@4/incline_up > ls: track@4/incline_up: No such file or directory [...] > diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile > index 6e00a9c69e58..dae2fe23cd2e 100644 > --- a/drivers/of/unittest-data/Makefile > +++ b/drivers/of/unittest-data/Makefile > @@ -1,11 +1,13 @@ > obj-y += testcases.dtb.o > obj-y += overlay.dtb.o > obj-y += overlay_bad_phandle.dtb.o > +obj-y += overlay_bad_symbol.dtb.o > obj-y += overlay_base.dtb.o There's no reason for these all to be 1 per line. Also, should the overlay dtb's be conditioned on CONFIG_OF_OVERLAY (or whatever we call it)? But this is fine. That can all be a followup patch.