Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755142AbdGKCtx (ORCPT ); Mon, 10 Jul 2017 22:49:53 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:41714 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752333AbdGKCtv (ORCPT ); Mon, 10 Jul 2017 22:49:51 -0400 Message-ID: <1499741386.12408.11.camel@mtksdaap41> Subject: Re: [PATCH v4 1/3] cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC From: Eddie Huang To: CC: , , , , , , , , , , , , , Date: Tue, 11 Jul 2017 10:49:46 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 32 Hi Sean, On Mon, 2017-07-10 at 22:23 +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with > single cluster and this hardware is also compatible with the existing > driver through enabling CPU frequency feature with operating-points-v2 > bindings. Also, this driver actually supports all MediaTek SoCs, the > Kconfig menu entry and file name itself should be updated with more > generic name to drop "MT8173" > > Signed-off-by: Sean Wang > Acked-by: Viresh Kumar > Reviewed-by: Jean Delvare > --- > drivers/cpufreq/Kconfig.arm | 7 +++---- > drivers/cpufreq/Makefile | 2 +- > drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++ > 3 files changed, 6 insertions(+), 5 deletions(-) > rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%) > As Viresh mentioned, there are already many drivers use "mtk" as filename prefix or postfix.To align with those files, I suggest use mtk-cpufreq.c.I think there are not too many values to change all "mtk-" to "mediatek-", but it is worth to have the same naming rule for mediatek upstream driver. Regards, Eddie.