Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754549AbdGKFrp (ORCPT ); Tue, 11 Jul 2017 01:47:45 -0400 Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:55044 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750821AbdGKFro (ORCPT ); Tue, 11 Jul 2017 01:47:44 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:7903:9010:10004:10400:10848:11232:11658:11914:12050:12296:12740:12760:12895:13069:13311:13357:13439:13618:14180:14659:14721:21060:21080:21451:21627:30054:30070:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: quilt72_902a7b640514 X-Filterd-Recvd-Size: 2428 Message-ID: <1499752060.4457.8.camel@perches.com> Subject: Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. From: Joe Perches To: Arvind Yadav , santosh@chelsio.com, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 10 Jul 2017 22:47:40 -0700 In-Reply-To: <8884bd80-b8d5-1c1e-5235-b0a0c173bc45@gmail.com> References: <0e68326e48e123c70191169a0c0da820237425ec.1499682619.git.arvind.yadav.cs@gmail.com> <1499706011.5468.15.camel@perches.com> <8884bd80-b8d5-1c1e-5235-b0a0c173bc45@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 37 On Tue, 2017-07-11 at 11:11 +0530, Arvind Yadav wrote: > Hi Joe, > > > On Monday 10 July 2017 10:30 PM, Joe Perches wrote: > > On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote: > > > attribute_groups are not supposed to change at runtime. All functions > > > working with attribute_groups provided by work > > > with const attribute_group. So mark the non-const structs as const. > > > > I think it's good you are doing all of these. > > > > Instead of individually sending these patches, could you > > please send a patch series for all of these attribute_group > > patches with a cover letter at the same time? > > > > That could make it easier for a trivial maintainer to apply > > all of these at once and not get some applied and others > > ignored or dropped on the floor. > > > > Once again, I will send all of patch together, But I have doubt. If it's > having > different maintainer. Example- 'net:' subsystem is having a different > different > maintainer. So do i need to add all the maintainer in single list. Which > can confuse > what patch is for what maintainer. Please suggest me. Please send individual patches, one per maintainer/subsystem as a series with a cover letter like: [PATCH 0/N] treewide: constify attribute_group structures [PATCH 1/N] chelsio: cxgb3: constify attribute_group [PATCH 2/N] chelsio: cxgb4: constify attribute_group ... [PATCH N/N] subsystem: constify attribute_group