Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755216AbdGKFyB (ORCPT ); Tue, 11 Jul 2017 01:54:01 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36744 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbdGKFyA (ORCPT ); Tue, 11 Jul 2017 01:54:00 -0400 Subject: Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. To: Joe Perches , santosh@chelsio.com, davem@davemloft.net References: <0e68326e48e123c70191169a0c0da820237425ec.1499682619.git.arvind.yadav.cs@gmail.com> <1499706011.5468.15.camel@perches.com> <8884bd80-b8d5-1c1e-5235-b0a0c173bc45@gmail.com> <1499752060.4457.8.camel@perches.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: <49d4a885-5b27-35a5-be2d-08d5a483429b@gmail.com> Date: Tue, 11 Jul 2017 11:23:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1499752060.4457.8.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1591 Lines: 43 Hi Joe, On Tuesday 11 July 2017 11:17 AM, Joe Perches wrote: > On Tue, 2017-07-11 at 11:11 +0530, Arvind Yadav wrote: >> Hi Joe, >> >> >> On Monday 10 July 2017 10:30 PM, Joe Perches wrote: >>> On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote: >>>> attribute_groups are not supposed to change at runtime. All functions >>>> working with attribute_groups provided by work >>>> with const attribute_group. So mark the non-const structs as const. >>> I think it's good you are doing all of these. >>> >>> Instead of individually sending these patches, could you >>> please send a patch series for all of these attribute_group >>> patches with a cover letter at the same time? >>> >>> That could make it easier for a trivial maintainer to apply >>> all of these at once and not get some applied and others >>> ignored or dropped on the floor. >>> >> Once again, I will send all of patch together, But I have doubt. If it's >> having >> different maintainer. Example- 'net:' subsystem is having a different >> different >> maintainer. So do i need to add all the maintainer in single list. Which >> can confuse >> what patch is for what maintainer. Please suggest me. > Please send individual patches, one per maintainer/subsystem > as a series with a cover letter like: > > [PATCH 0/N] treewide: constify attribute_group structures > [PATCH 1/N] chelsio: cxgb3: constify attribute_group > [PATCH 2/N] chelsio: cxgb4: constify attribute_group > ... > [PATCH N/N] subsystem: constify attribute_group > Thank you, I will follow as per your suggestion. Regards, ~arvind