Date: Wed, 18 Jun 2003 10:44:52 +0200
From: Andi Kleen <ak@suse.de>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: 2.5.72 x86-generic missing enable_apic_mode()
Message-ID: <20030618084452.GD23037@wotan.suse.de>
References: <200306180827.h5I8Rtl27217@freya.yggdrasil.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200306180827.h5I8Rtl27217@freya.yggdrasil.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1021
Lines: 25

On Wed, Jun 18, 2003 at 01:27:55AM -0700, Adam J. Richter wrote:
> 	x86-generic in 2.5.72 does not compile, because
> include/asm-i386/mach-generic/mach_apic.h does not define
> enable_apic_mode().  Although I kludged around this, by
> just defining enable_apic_mode() as nothing (since it is
> apparently nothing for all x86 platforms except es7000),
> I imagine that the correct definition is
> 
> #define enable_apic_mode (genapic->enable_apic_mode)
> 
> 	...along with some other changes to declare
> genapic->enable_apic_mode and initialize it for each platform
> type.

It should be enough to add it to the genapic structure in
asm-i386/genapic.h and also to the APIC_INIT macro in the same file.

(assuming that it is properly defined for default,bigsmp,summit) 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/