DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EF0CE80E75
Message-ID: <1499753648.8257.3.camel@redhat.com>
Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation
From: Gerd Hoffmann <kraxel@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
        Tina Zhang <tina.zhang@intel.com>, alex.williamson@redhat.com,
        chris@chris-wilson.co.uk, zhenyuw@linux.intel.com,
        zhiyuan.lv@intel.com, zhi.a.wang@intel.com, kevin.tian@intel.com,
        daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Date: Tue, 11 Jul 2017 08:14:08 +0200
In-Reply-To: <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com>
References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com>
         <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 621
Lines: 26

  Hi,

> > +struct vfio_device_query_gfx_plane {
> > +	__u32 argsz;
> > +	__u32 flags;
> > +	struct vfio_device_gfx_plane_info plane_info;
> > +	__u32 plane_type;
> > +	__s32 fd; /* dma-buf fd */
> > +	__u32 plane_id;
> > +};
> > +
> 
> It would be better to have comment here about what are expected
> values
> for plane_type and plane_id.

plane_type is DRM_PLANE_TYPE_*.

yes, a comment saying so would be good, same for drm_format which is
DRM_FORMAT_*.  While looking at these two: renaming plane_type to
drm_plane_type (for consistency) is probably a good idea too.

plane_id needs a specification.

cheers,
  Gerd