Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755288AbdGKHW1 (ORCPT ); Tue, 11 Jul 2017 03:22:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:33386 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755235AbdGKHW0 (ORCPT ); Tue, 11 Jul 2017 03:22:26 -0400 Date: Tue, 11 Jul 2017 09:22:23 +0200 From: Michal Hocko To: Vlastimil Babka Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com Subject: Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Message-ID: <20170711072223.GH24852@dhcp22.suse.cz> References: <20170710111059.30795-1-khandual@linux.vnet.ibm.com> <20170710134917.GB19645@dhcp22.suse.cz> <20170711060354.GA24852@dhcp22.suse.cz> <4c182da0-6c84-df67-b173-6960fac0544a@suse.cz> <20170711065030.GE24852@dhcp22.suse.cz> <337a8a4c-1f27-7371-409d-6a9f181b3871@suse.cz> <20170711071612.GG24852@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711071612.GG24852@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 434 Lines: 13 On Tue 11-07-17 09:16:12, Michal Hocko wrote: > On Tue 11-07-17 08:56:04, Vlastimil Babka wrote: [...] > > It doesn't explain why it's redundant, indeed. Unfortunately, the commit > > f106af4e90ea ("fix checks for expand-in-place mremap") which added this, > > also doesn't explain why it's needed. > > Because it doesn't do anything AFAICS. Well, it does actually. I have missed security_mmap_addr hook. -- Michal Hocko SUSE Labs