Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755402AbdGKHaD (ORCPT ); Tue, 11 Jul 2017 03:30:03 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34940 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755222AbdGKHaA (ORCPT ); Tue, 11 Jul 2017 03:30:00 -0400 From: Arvind Yadav To: davem@davemloft.net, wg@grandegger.com, mkl@pengutronix.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures. Date: Tue, 11 Jul 2017 12:59:18 +0530 Message-Id: <1499758158-24741-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499758158-24741-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1499758158-24741-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 35 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 11800 368 0 12168 2f88 drivers/net/can/janz-ican3.o File size After adding 'const': text data bss dec hex filename 11864 304 0 12168 2f88 drivers/net/can/janz-ican3.o Signed-off-by: Arvind Yadav --- Changes in v2: Added cover later. drivers/net/can/janz-ican3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c index 2ba1a81..12a53c8 100644 --- a/drivers/net/can/janz-ican3.c +++ b/drivers/net/can/janz-ican3.c @@ -1875,7 +1875,7 @@ static DEVICE_ATTR(termination, S_IWUSR | S_IRUGO, ican3_sysfs_show_term, NULL, }; -static struct attribute_group ican3_sysfs_attr_group = { +static const struct attribute_group ican3_sysfs_attr_group = { .attrs = ican3_sysfs_attrs, }; -- 1.9.1