Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932385AbdGKHfk (ORCPT ); Tue, 11 Jul 2017 03:35:40 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33195 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755323AbdGKHeq (ORCPT ); Tue, 11 Jul 2017 03:34:46 -0400 From: Arvind Yadav To: m.grzeschik@pengutronix.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures. Date: Tue, 11 Jul 2017 13:04:18 +0530 Message-Id: <1499758458-24920-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499758458-24920-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1499758458-24920-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1166 Lines: 35 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 3409 948 28 4385 1121 drivers/net/arcnet/com20020-pci.o File size After adding 'const': text data bss dec hex filename 3473 884 28 4385 1121 drivers/net/arcnet/com20020-pci.o Signed-off-by: Arvind Yadav --- Changes in v2: Added cover later. drivers/net/arcnet/com20020-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index 01cab95..eb7f767 100644 --- a/drivers/net/arcnet/com20020-pci.c +++ b/drivers/net/arcnet/com20020-pci.c @@ -109,7 +109,7 @@ static ssize_t backplane_mode_show(struct device *dev, NULL, }; -static struct attribute_group com20020_state_group = { +static const struct attribute_group com20020_state_group = { .name = NULL, .attrs = com20020_state_attrs, }; -- 1.9.1