Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755573AbdGKIav (ORCPT ); Tue, 11 Jul 2017 04:30:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:38963 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755560AbdGKIau (ORCPT ); Tue, 11 Jul 2017 04:30:50 -0400 Date: Tue, 11 Jul 2017 10:30:47 +0200 From: Petr Mladek To: Pierre Kuo Cc: sergey.senozhatsky@gmail.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH v2] printk: Modify operators of printed_len and text_len Message-ID: <20170711083047.GO23069@pathway.suse.cz> References: <1499755255-6258-1-git-send-email-vichy.kuo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499755255-6258-1-git-send-email-vichy.kuo@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 17 On Tue 2017-07-11 14:40:55, Pierre Kuo wrote: > With commit ("printk: report lost messages in printk > safe/nmi contexts") and commit <8b1742c9c207> ("printk: remove zap_locks() > function"), it seems we can remove initialization, "=0", of text_len and > directly assign result of log_output to printed_len. Just one small thing. The <> brackets should not be there around the sha1 commit id. Otherwise, the patch looks fine to me. Acked-by: Petr Mladek You do not need to resend the patch. I'll remove the brackets when applying the patch. I'll wait few more days just in case anyone has more comments on this patch. Best Regards, Petr