Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbdGKJMn (ORCPT ); Tue, 11 Jul 2017 05:12:43 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33424 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064AbdGKJMl (ORCPT ); Tue, 11 Jul 2017 05:12:41 -0400 Date: Tue, 11 Jul 2017 11:12:36 +0200 From: Daniel Vetter To: Gerd Hoffmann Cc: Kirti Wankhede , Tina Zhang , alex.williamson@redhat.com, chris@chris-wilson.co.uk, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, zhi.a.wang@intel.com, kevin.tian@intel.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Message-ID: <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> Mail-Followup-To: Gerd Hoffmann , Kirti Wankhede , Tina Zhang , alex.williamson@redhat.com, chris@chris-wilson.co.uk, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, zhi.a.wang@intel.com, kevin.tian@intel.com, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com> <1499753648.8257.3.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499753648.8257.3.camel@redhat.com> X-Operating-System: Linux phenom 4.11.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 33 On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote: > Hi, > > > > +struct vfio_device_query_gfx_plane { > > > + __u32 argsz; > > > + __u32 flags; > > > + struct vfio_device_gfx_plane_info plane_info; > > > + __u32 plane_type; > > > + __s32 fd; /* dma-buf fd */ > > > + __u32 plane_id; > > > +}; > > > + > > > > It would be better to have comment here about what are expected > > values > > for plane_type and plane_id. > > plane_type is DRM_PLANE_TYPE_*. > > yes, a comment saying so would be good, same for drm_format which is > DRM_FORMAT_*. While looking at these two: renaming plane_type to > drm_plane_type (for consistency) is probably a good idea too. > > plane_id needs a specification. Why do you need plane_type? With universal planes the plane_id along is sufficient to identify a plane on a given drm device instance. I'd just remove it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch