Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753349AbdGKJQu convert rfc822-to-8bit (ORCPT ); Tue, 11 Jul 2017 05:16:50 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:9818 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926AbdGKJQs (ORCPT ); Tue, 11 Jul 2017 05:16:48 -0400 From: "Gonglei (Arei)" To: Paolo Bonzini CC: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , longpeng , "Huangweidong (C)" , "wangxin (U)" , =?iso-8859-2?Q?Radim_Kr=E8m=E1=F8?= Subject: RE: [PATCH CFT 0/4] VT-d PI fixes Thread-Topic: [PATCH CFT 0/4] VT-d PI fixes Thread-Index: AQHS+iOBgGq6mkBWckSztr5Weri1laJOU75A Date: Tue, 11 Jul 2017 09:16:25 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020DA30F625@DGGEMA505-MBX.china.huawei.com> References: <20170606105707.23207-1-pbonzini@redhat.com> <33183CC9F5247A488A2544077AF19020DA2C98CC@DGGEMA505-MBX.china.huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.18.62] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.59649776.012D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.186, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 099194e9f57b135004208484ccb78d4b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 52 > -----Original Message----- > From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On > Behalf Of Paolo Bonzini > Sent: Tuesday, July 11, 2017 4:56 PM > To: Gonglei (Arei) > Cc: linux-kernel@vger.kernel.org; kvm@vger.kernel.org; longpeng; > Huangweidong (C); wangxin (U); Radim Kr?m?? > Subject: Re: [PATCH CFT 0/4] VT-d PI fixes > > On 07/06/2017 11:33, Gonglei (Arei) wrote: > > We are testing your patch, but maybe need some time to report > > the results because it's not an inevitable problem. > > > > Meanwhile we also try to find a possible scenario of non-hotplugging to > > explain the double-add warnings. > > Hi Lei, > > do you have any updates? Dear Paolo, Thanks for kicking me :) TBH, thinking about the reliability of productive project (we use kvm-4.4), we applied the patch you used in fedora pastebin, and the bug seems gone after one month's testing. diff --git a/source/x86/vmx.c b/source/x86/vmx.c index 79012cf..efc611f 100644 --- a/source/x86/vmx.c +++ b/source/x86/vmx.c @@ -11036,8 +11036,9 @@ static void pi_post_block(struct kvm_vcpu *vcpu) unsigned int dest; unsigned long flags; - if (!kvm_arch_has_assigned_device(vcpu->kvm) || - !irq_remapping_cap(IRQ_POSTING_CAP)) + if ((vcpu->pre_pcpu == -1) && + (!kvm_arch_has_assigned_device(vcpu->kvm) || + !irq_remapping_cap(IRQ_POSTING_CAP))) return; > I would like to get at least the first three > patches in 4.13. > I think they are okay to me for upstream. Thanks, -Gonglei