Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932398AbdGKJTW (ORCPT ); Tue, 11 Jul 2017 05:19:22 -0400 Received: from sym2.noone.org ([178.63.92.236]:52553 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932142AbdGKJTU (ORCPT ); Tue, 11 Jul 2017 05:19:20 -0400 Date: Tue, 11 Jul 2017 11:19:16 +0200 From: Tobias Klauser To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 17/28] nios2: remove unneeded arch/nios2/include/(generated/)asm/signal.h Message-ID: <20170711091916.GG5851@distanz.ch> References: <1499625180-8067-1-git-send-email-yamada.masahiro@socionext.com> <1499625180-8067-18-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499625180-8067-18-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 21 On 2017-07-09 at 20:32:49 +0200, Masahiro Yamada wrote: > Currently, NIOS2 has three signal.h files under arch/nios2/include: > > [1] arch/nios2/include/asm/signal.h > [2] arch/nios2/include/uapi/asm/signal.h > [3] arch/nios2/include/generated/asm/signal.h > > [3] is build-time generated by scripts/Makefile.asm-generic. > However, -I$(srctree)/arch/$(hdr-arch)/include search path is listed > before -I$(objtree)/arch/$(hdr-arch)/include/generated in LINUXINCLUDE. > Therefore [1] is always included instead of [3]. Remove [3] which > is never included. > > If we look at [1], it just includes [2]. So, [1] can be removed > as well. > > Signed-off-by: Masahiro Yamada Reviewed-by: Tobias Klauser Looks good, thanks!