Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755662AbdGKJ3R (ORCPT ); Tue, 11 Jul 2017 05:29:17 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33572 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755413AbdGKJ3O (ORCPT ); Tue, 11 Jul 2017 05:29:14 -0400 From: Arvind Yadav To: bhelgaas@google.com, paulus@samba.org, mpe@ellerman.id.au, benh@kernel.crashing.org Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 3/3] PCI: hotplug: constify attribute_group structures. Date: Tue, 11 Jul 2017 14:58:44 +0530 Message-Id: <1499765324-617-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499765324-617-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1499765324-617-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1104 Lines: 32 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o File size After adding 'const': text data bss dec hex filename 482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o Signed-off-by: Arvind Yadav --- drivers/pci/hotplug/rpadlpar_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c index a796301..edb5d8a 100644 --- a/drivers/pci/hotplug/rpadlpar_sysfs.c +++ b/drivers/pci/hotplug/rpadlpar_sysfs.c @@ -102,7 +102,7 @@ static ssize_t remove_slot_show(struct kobject *kobj, NULL, }; -static struct attribute_group dlpar_attr_group = { +static const struct attribute_group dlpar_attr_group = { .attrs = default_attrs, }; -- 1.9.1