Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755706AbdGKMp4 (ORCPT ); Tue, 11 Jul 2017 08:45:56 -0400 Received: from gloria.sntech.de ([95.129.55.99]:38358 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533AbdGKMpy (ORCPT ); Tue, 11 Jul 2017 08:45:54 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Mark Yao Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop Date: Tue, 11 Jul 2017 14:45:43 +0200 Message-ID: <7391489.lxuf2bMt0N@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1499776958-17062-1-git-send-email-mark.yao@rock-chips.com> References: <1499776908-16811-1-git-send-email-mark.yao@rock-chips.com> <1499776958-17062-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1292 Lines: 41 Hi Mark, Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao: > Signed-off-by: Mark Yao > --- > Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 > ++++ 1 file changed, 4 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index > 9eb3f0a..11fa3b0 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > @@ -8,8 +8,12 @@ Required properties: > - compatible: value should be one of the following > "rockchip,rk3036-vop"; > "rockchip,rk3288-vop"; > + "rockchip,rk3368-vop"; > + "rockchip,rk3366-vop"; > "rockchip,rk3399-vop-big"; > "rockchip,rk3399-vop-lit"; > + "rockchip,rk322x-vop"; please don't use wildcards in devicetree compatibles. We've somehow standardized on using rk3228 for both the rk3228 and rk3229 (which are nearly the same soc with some speed adjustments) So, + "rockchip,rk3228-vop"; please Thanks Heiko > + "rockchip,rk3328-vop"; > > - interrupts: should contain a list of all VOP IP block interrupts in the > order: VSYNC, LCD_SYSTEM. The interrupt specifier