Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933116AbdGKOXz convert rfc822-to-8bit (ORCPT ); Tue, 11 Jul 2017 10:23:55 -0400 Received: from smtp-out6.electric.net ([192.162.217.195]:52682 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932779AbdGKOXv (ORCPT ); Tue, 11 Jul 2017 10:23:51 -0400 From: David Laight To: "'Gleb Fotengauer-Malinovskiy'" , Aleksa Sarai , Greg Kroah-Hartman CC: "linux-arch@vger.kernel.org" , "linux-mips@linux-mips.org" , Valentin Rothberg , "linux-parisc@vger.kernel.org" , Arnd Bergmann , "linux-sh@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "linux-alpha@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Dmitry V. Levin" , Jiri Slaby , "sparclinux@vger.kernel.org" , Christian Brauner , "linuxppc-dev@lists.ozlabs.org" Subject: RE: [PATCH] tty: Fix TIOCGPTPEER ioctl definition Thread-Topic: [PATCH] tty: Fix TIOCGPTPEER ioctl definition Thread-Index: AQHS+eU5TVOVgkfTM0KcxVD2Vg8Z7qJOrntA Date: Tue, 11 Jul 2017 14:23:29 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD003758C@AcuExch.aculab.com> References: <20170711001207.GA11642@glebfm.cloud.tilaa.com> In-Reply-To: <20170711001207.GA11642@glebfm.cloud.tilaa.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 14 From: Linuxppc-dev Gleb Fotengauer-Malinovskiy > Sent: 11 July 2017 01:12 > This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag > because it doesn't copy anything from/to userspace to access the > argument. > > Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl") ... > -#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */ > +#define TIOCGPTPEER _IO('T', 0x41) /* Safely open the slave */ This is a user API change. When was the ioctl added? David