Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933183AbdGKOjc (ORCPT ); Tue, 11 Jul 2017 10:39:32 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36541 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932678AbdGKOja (ORCPT ); Tue, 11 Jul 2017 10:39:30 -0400 Subject: Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio To: peterz@infradead.org, mingo@redhat.com, corbet@lwn.net, "open list:LOCKING PRIMITIVES" , "open list:DOCUMENTATION" Cc: Steven Rostedt , Sebastian Siewior , Mathieu Poirier , Juri Lelli , Thomas Gleixner References: <1499395922-542-1-git-send-email-alex.shi@linaro.org> <1499395922-542-3-git-send-email-alex.shi@linaro.org> From: Alex Shi Message-ID: Date: Tue, 11 Jul 2017 22:39:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1499395922-542-3-git-send-email-alex.shi@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 35 Any comments for this little change? It's passed on 0day testing. Thanks Alex On 07/07/2017 10:52 AM, Alex Shi wrote: > We don't need to adjust prio before new pi_waiter adding. The prio > only need update after pi_waiter change or task priority change. > > Signed-off-by: Alex Shi > Cc: Steven Rostedt > Cc: Sebastian Siewior > Cc: Mathieu Poirier > Cc: Juri Lelli > Cc: Thomas Gleixner > To: linux-kernel@vger.kernel.org > To: Ingo Molnar > To: Peter Zijlstra > --- > kernel/locking/rtmutex.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c > index 28cd09e..d1fe41f 100644 > --- a/kernel/locking/rtmutex.c > +++ b/kernel/locking/rtmutex.c > @@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, > return -EDEADLK; > > raw_spin_lock(&task->pi_lock); > - rt_mutex_adjust_prio(task); > waiter->task = task; > waiter->lock = lock; > waiter->prio = task->prio; >