Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932774AbdGKPVL (ORCPT ); Tue, 11 Jul 2017 11:21:11 -0400 Received: from foss.arm.com ([217.140.101.70]:46514 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932291AbdGKPVJ (ORCPT ); Tue, 11 Jul 2017 11:21:09 -0400 Subject: Re: [PATCH v2 02/10] cpufreq: provide data for frequency-invariant load-tracking support To: Viresh Kumar , "Rafael J. Wysocki" Cc: Peter Zijlstra , "Rafael J. Wysocki" , Linux Kernel Mailing List , Linux PM , Russell King - ARM Linux , Greg Kroah-Hartman , Russell King , Catalin Marinas , Will Deacon , Juri Lelli , Vincent Guittot , Morten Rasmussen References: <20170706094948.8779-1-dietmar.eggemann@arm.com> <12829054.TWIodSo4bb@aspire.rjw.lan> <20170710065443.GG2928@vireshk-i7> <4673356.gkeX7KYvlb@aspire.rjw.lan> <20170711063944.GA17115@vireshk-i7> From: Dietmar Eggemann Message-ID: Date: Tue, 11 Jul 2017 16:21:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170711063944.GA17115@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 25 On 11/07/17 07:39, Viresh Kumar wrote: > On 10-07-17, 14:46, Rafael J. Wysocki wrote: >> This particular change is about a new feature, so making it in the core is OK >> in two cases IMO: (a) when you actively want everyone to be affected by it and > > IMO this change should be done for the whole ARM architecture. And if some > regression happens due to this, then we come back and solve it. > >> (b) when the effect of it on the old systems should not be noticeable. > > I am not sure about the effects of this on performance really. > > @Dietmar: Any inputs for that ? Like I said in the other email, since for (future) arm/arm64 fast-switch driver, the return value of cpufreq_driver->fast_switch() does not give us the information that the frequency value did actually change, we have to implement arch_set_freq_scale() in the driver. This means that we probably only implement this in the subset of drivers which will be used in platforms on which we want to have frequency-invariant load-tracking. A future aperf/mperf like counter FIE solution can give us arch-wide support when those counters are available.