Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933464AbdGKPYv (ORCPT ); Tue, 11 Jul 2017 11:24:51 -0400 Received: from mga07.intel.com ([134.134.136.100]:26715 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932456AbdGKPYu (ORCPT ); Tue, 11 Jul 2017 11:24:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,347,1496127600"; d="scan'208";a="991685056" Date: Tue, 11 Jul 2017 08:24:49 -0700 From: Andi Kleen To: kan.liang@intel.com Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, jolsa@redhat.com, acme@kernel.org, eranian@google.com Subject: Re: [PATCH V3] perf/x86/intel/uncore: remove nonexistent clockticks event for client uncore Message-ID: <20170711152449.GB3441@tassilo.jf.intel.com> References: <20170711143346.2396-1-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711143346.2396-1-kan.liang@intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 384 Lines: 11 > User observable change with the patch. > clockticks event is removed from CBOX. User may need to change their > script to use uncore_clock/clockticks/ instead. I don't think we can do that and break everyone's scripts. Have to keep the old behavior, even though it is not ideal. Or you fix the the uncore subsystem to support a separate attribute array for the first cbox. -Andi