Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933630AbdGKPny (ORCPT ); Tue, 11 Jul 2017 11:43:54 -0400 Received: from mail-qk0-f180.google.com ([209.85.220.180]:33412 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933384AbdGKPnw (ORCPT ); Tue, 11 Jul 2017 11:43:52 -0400 MIME-Version: 1.0 In-Reply-To: <2519579.h5lvWVZraV@aspire.rjw.lan> References: <20170708000303.21863-1-dbasehore@chromium.org> <4255011.FH94tfVCB1@aspire.rjw.lan> <2519579.h5lvWVZraV@aspire.rjw.lan> From: Len Brown Date: Tue, 11 Jul 2017 11:43:51 -0400 X-Google-Sender-Auth: VZFs7IlhGMkhmFhz2rvyt5Zdcuw Message-ID: Subject: Re: [PATCH v5 5/5] intel_idle: Add S0ix validation To: "Rafael J. Wysocki" Cc: "dbasehore ." , linux-kernel , Thomas Gleixner , Ingo Molnar , Rajneesh Bhardwaj , X86 ML , Platform Driver , Len Brown , Linux-pm mailing list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 521 Lines: 15 I acknowledge the specific need for this check to assure a great user-experience on specific hardware. I also concur the motivation to make mechanisms general and generic so they can be re-used. However, it isn't clear to me that this check would be used outside of some very specific scenarios, and so we may be trying too hard to make it general, and the code would be simpler if we focus on that. We can always make it more general when we have more use-cases... -- Len Brown, Intel Open Source Technology Center