Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755920AbdGKPzh (ORCPT ); Tue, 11 Jul 2017 11:55:37 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9738 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755639AbdGKPzg (ORCPT ); Tue, 11 Jul 2017 11:55:36 -0400 Subject: Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion To: Yijing Wang , , References: <1499670369-44143-1-git-send-email-wangyijing@huawei.com> <1499670369-44143-3-git-send-email-wangyijing@huawei.com> CC: , , , , , , , , , , , , , , , , , , Linuxarm From: John Garry Message-ID: Date: Tue, 11 Jul 2017 16:54:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1499670369-44143-3-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.93.105] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0204.5964F4EA.0100,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c01c2c714563d78421eded34f1ec3197 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 28 On 10/07/2017 08:06, Yijing Wang wrote: > No one uses the port_gone_completion in struct asd_sas_port, > clean it out. This seems like a reasonable tidy-up patch which could be taken in isolation, having no dependency on the rest of the series. > > Signed-off-by: Yijing Wang > --- > include/scsi/libsas.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h > index c41328d..628f48b 100644 > --- a/include/scsi/libsas.h > +++ b/include/scsi/libsas.h > @@ -263,8 +263,6 @@ struct sas_discovery { > /* The port struct is Class:RW, driver:RO */ > struct asd_sas_port { > /* private: */ > - struct completion port_gone_completion; > - > struct sas_discovery disc; > struct domain_device *port_dev; > spinlock_t dev_list_lock; >