Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756200AbdGKRX4 convert rfc822-to-8bit (ORCPT ); Tue, 11 Jul 2017 13:23:56 -0400 Received: from g9t1613g.houston.hpe.com ([15.241.32.99]:47782 "EHLO g9t1613g.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756184AbdGKRXy (ORCPT ); Tue, 11 Jul 2017 13:23:54 -0400 From: "Elliott, Robert (Persistent Memory)" To: Suganath Prabu S , "JBottomley@Parallels.com" , "jejb@kernel.org" , "hch@infradead.org" CC: "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "Sathya.Prakash@broadcom.com" , "kashyap.desai@broadcom.com" , "linux-kernel@vger.kernel.org" , "chaitra.basappa@broadcom.com" , "sreekanth.reddy@broadcom.com" , "linux-nvme@lists.infradead.org" Subject: RE: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128 Thread-Topic: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128 Thread-Index: AQHS+iQQzXb8S4VYTEOOFrsP/+8Jd6JO36fg Date: Tue, 11 Jul 2017 17:23:33 +0000 Message-ID: References: <1499763313-7214-1-git-send-email-suganath-prabu.subramani@broadcom.com> <1499763313-7214-6-git-send-email-suganath-prabu.subramani@broadcom.com> In-Reply-To: <1499763313-7214-6-git-send-email-suganath-prabu.subramani@broadcom.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.203.227.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AT5PR84MB0084;7:6wEnH61+jPjJGHknJQE/O6fRYU3+f9CUwxC+En61dfM0tcl7nEsrMoBVmzrdNtBDiXmYexwebJpbgGHxTum0dfrdE3tsgs/wRxWTGV10aECKP2aMYMgZxHsMwRm2pNz6oe1o1ywhF0oH57H3XoJ6UheaRRGiLlZm+NEvXGLTlyrQgoFJ2BGnfI3airTYlFZEsQ404gcV0ZRb+N6o99GLA7v7026L+X3yMCK6lTJdfx3kN/sUeVh8b5O67YGoPgHjurnVzAS0CFEsCcxzF7HX8KjBZUTCkNt58QULvg6s1sq/8J06qz4jkRdjopwcd+xKkPR238yYJiwuqOl2+cJXlRNXGnMuw2dLxX6MXbGozi5JQ2akkrzkvhsc4fERDaD1uFz23rwp0AsQDbX5HQZNKYZkd5MldYmSCezL5zUtUPrxBPynRFmUb+XLXQFyvPAjCwh9nD9C0X1xAnJjs70ME7bYLf7eIS6dcjUDQlHaToRdYJvfQeYHVCQnAhgvU1dK2WGLNsAOaiKbwK7Qbr/5fwJCOZsHZa+riIwlfSCuPVN5JkLD2KlyC5X822JZIvAKIP0Vp6D2vb3mrSPkz7ULP+nB/oto1RL9cA5FWbnINGVw9K956rnZaDmos8ls+H29k9YL64FJJcRBeB6J11j5KkwvZ+JSsi1BsFg68xT9mHXAIdMla1aXyhM9N7WZVkw0rpJ0kHegXlXyXhFev1Hqv0iwlxzd0aQhDwhhNQg85KoKc5ikZjSzMancGawybBTXAiOMrMHvazY8SmrreEiw6oAOL0UWQspVP3l+MwVmSmw= x-ms-office365-filtering-correlation-id: 6ba3de30-1335-447e-7e12-08d4c8818ec7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AT5PR84MB0084; x-ms-traffictypediagnostic: AT5PR84MB0084: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AT5PR84MB0084;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AT5PR84MB0084; x-forefront-prvs: 0365C0E14B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39840400002)(39860400002)(39400400002)(39850400002)(39410400002)(229853002)(66066001)(189998001)(3846002)(6246003)(102836003)(6116002)(38730400002)(2950100002)(6506006)(53936002)(50986999)(2501003)(5250100002)(76176999)(54356999)(6436002)(9686003)(3660700001)(55016002)(54906002)(7736002)(6306002)(3280700002)(2201001)(86362001)(8676002)(25786009)(81166006)(7696004)(966005)(74316002)(478600001)(305945005)(7416002)(4326008)(2900100001)(33656002)(5660300001)(2906002)(8936002)(14454004)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0084;H:AT5PR84MB0082.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2017 17:23:33.6706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0084 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 562 Lines: 21 > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h > @@ -115,7 +115,7 @@ > > #define MPT3SAS_RAID_MAX_SECTORS 8192 > #define MPT3SAS_HOST_PAGE_SIZE_4K 12 > - > +#define MPT3SAS_NVME_QUEUE_DEPTH 128 ... > + /*TODO-right Queue Depth?*/ > + qdepth = MPT3SAS_NVME_QUEUE_DEPTH; > + ds = "NVMe"; The native NVMe driver is getting a modparam to set that value (rather than using a #define of 1024) in this patch: http://lists.infradead.org/pipermail/linux-nvme/2017-July/011734.html Perhaps this driver should do the same. --- Robert Elliott, HPE Persistent Memory