Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756249AbdGKR0t (ORCPT ); Tue, 11 Jul 2017 13:26:49 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:49546 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756215AbdGKR0b (ORCPT ); Tue, 11 Jul 2017 13:26:31 -0400 Date: Tue, 11 Jul 2017 13:26:23 -0400 From: Johannes Weiner To: Michal Hocko Cc: Andrew Morton , Cristopher Lameter , Vlastimil Babka , linux-mm@kvack.org, LKML Subject: Re: [PATCH] vmemmap, memory_hotplug: fallback to base pages for vmmap Message-ID: <20170711172623.GB961@cmpxchg.org> References: <20170711134204.20545-1-mhocko@kernel.org> <20170711142558.GE11936@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711142558.GE11936@dhcp22.suse.cz> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 14 Hi Michael, On Tue, Jul 11, 2017 at 04:25:58PM +0200, Michal Hocko wrote: > Ohh, scratch that. The patch is bogus. I have completely missed that > vmemmap_populate_hugepages already falls back to > vmemmap_populate_basepages. I have to revisit the bug report I have > received to see what happened apart from the allocation warning. Maybe > we just want to silent that warning. Yep, this should be fixed in 8e2cdbcb86b0 ("x86-64: fall back to regular page vmemmap on allocation failure"). I figure it's good to keep some sort of warning there, though, as it could have performance implications when we fall back to base pages.