Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756046AbdGKRyX (ORCPT ); Tue, 11 Jul 2017 13:54:23 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51837 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755866AbdGKRyV (ORCPT ); Tue, 11 Jul 2017 13:54:21 -0400 X-ME-Sender: X-Sasl-enc: WdSCI61k+XdDQ/nWXCX0hI9PlbNifkaK5xzxFks6G2Wt 1499795660 Date: Tue, 11 Jul 2017 18:54:32 +0100 From: Andrey Utkin To: Colin King Cc: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static Message-ID: <20170711175432.GA6230@dell-m4800> References: <20170710185103.18461-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170710185103.18461-1-colin.king@canonical.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 619 Lines: 17 On Mon, Jul 10, 2017 at 07:51:03PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate const array saa7128_regs_ntsc on the stack but insteaed make > it static. Makes the object code smaller and saves nearly 840 bytes > > Before: > text data bss dec hex filename > 9218 360 0 9578 256a solo6x10-tw28.o > > After: > text data bss dec hex filename > 8237 504 0 8741 2225 solo6x10-tw28.o > > Signed-off-by: Colin Ian King Acked-by: Andrey Utkin