Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756532AbdGKSzu (ORCPT ); Tue, 11 Jul 2017 14:55:50 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34920 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756487AbdGKSzt (ORCPT ); Tue, 11 Jul 2017 14:55:49 -0400 Subject: Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures. To: Arvind Yadav , bhelgaas@google.com, paulus@samba.org, mpe@ellerman.id.au, benh@kernel.crashing.org Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <1499765324-617-1-git-send-email-arvind.yadav.cs@gmail.com> <1499765324-617-2-git-send-email-arvind.yadav.cs@gmail.com> From: Tyrel Datwyler Date: Tue, 11 Jul 2017 11:55:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1499765324-617-2-git-send-email-arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17071118-0012-0000-0000-000014A51730 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007350; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00886138; UDB=6.00442301; IPR=6.00666287; BA=6.00005468; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016181; XFM=3.00000015; UTC=2017-07-11 18:55:47 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17071118-0013-0000-0000-00004E8CFA74 Message-Id: <97d8f7b5-7939-6abb-4883-4582a16f374e@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-11_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707110305 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 16 On 07/11/2017 02:28 AM, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work > with const attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o > > File size After adding 'const': > text data bss dec hex filename > 482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o > > Signed-off-by: Arvind Yadav Reviewed-by: Tyrel Datwyler