Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934026AbdGKVl5 (ORCPT ); Tue, 11 Jul 2017 17:41:57 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:35115 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933856AbdGKVly (ORCPT ); Tue, 11 Jul 2017 17:41:54 -0400 Date: Tue, 11 Jul 2017 14:41:51 -0700 From: Bjorn Andersson To: "Gustavo A. R. Silva" Cc: Linus Walleij , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: msm: constify gpio_chip structure Message-ID: <20170711214151.GC20973@minitux> References: <20170711183414.GA24866@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711183414.GA24866@embeddedgus> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1496 Lines: 46 On Tue 11 Jul 11:34 PDT 2017, Gustavo A. R. Silva wrote: [..] > In the following log you can see a significant difference in the code size > and data segment, hence in the dec segment. This log is the output "dec" is for "decimal" and is the sum of text, data and bss... > of the size command, before and after the code change: > > before: > text data bss dec hex filename > 13129 2808 192 16129 3f01 drivers/pinctrl/qcom/pinctrl-msm.o > > after: > text data bss dec hex filename > 12839 2720 192 15751 3d87 drivers/pinctrl/qcom/pinctrl-msm.o > > Signed-off-by: Gustavo A. R. Silva Good catch, thanks! Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 273badd..245ccfd 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -521,7 +521,7 @@ static void msm_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) > #define msm_gpio_dbg_show NULL > #endif > > -static struct gpio_chip msm_gpio_template = { > +static const struct gpio_chip msm_gpio_template = { > .direction_input = msm_gpio_direction_input, > .direction_output = msm_gpio_direction_output, > .get_direction = msm_gpio_get_direction, > -- > 2.5.0 >