Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934270AbdGKV5y (ORCPT ); Tue, 11 Jul 2017 17:57:54 -0400 Received: from gateway31.websitewelcome.com ([192.185.144.91]:47232 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934252AbdGKV5v (ORCPT ); Tue, 11 Jul 2017 17:57:51 -0400 Date: Tue, 11 Jul 2017 16:57:38 -0500 Message-ID: <20170711165738.Horde.yi2IJ5rdfgW06y48YYbFP4z@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Bjorn Andersson Cc: Linus Walleij , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: msm: constify gpio_chip structure References: <20170711183414.GA24866@embeddedgus> <20170711214151.GC20973@minitux> In-Reply-To: <20170711214151.GC20973@minitux> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dV3A2-0028LE-Ho X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:60293 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 14 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 65 Hi Bjorn, Quoting Bjorn Andersson : > On Tue 11 Jul 11:34 PDT 2017, Gustavo A. R. Silva wrote: > [..] >> In the following log you can see a significant difference in the code size >> and data segment, hence in the dec segment. This log is the output > > "dec" is for "decimal" and is the sum of text, data and bss... > You are right. :) >> of the size command, before and after the code change: >> >> before: >> text data bss dec hex filename >> 13129 2808 192 16129 3f01 drivers/pinctrl/qcom/pinctrl-msm.o >> >> after: >> text data bss dec hex filename >> 12839 2720 192 15751 3d87 drivers/pinctrl/qcom/pinctrl-msm.o >> >> Signed-off-by: Gustavo A. R. Silva > > Good catch, thanks! > Absolutely, glad to help! > Reviewed-by: Bjorn Andersson > > Regards, > Bjorn > >> --- >> drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c >> b/drivers/pinctrl/qcom/pinctrl-msm.c >> index 273badd..245ccfd 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-msm.c >> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c >> @@ -521,7 +521,7 @@ static void msm_gpio_dbg_show(struct seq_file >> *s, struct gpio_chip *chip) >> #define msm_gpio_dbg_show NULL >> #endif >> >> -static struct gpio_chip msm_gpio_template = { >> +static const struct gpio_chip msm_gpio_template = { >> .direction_input = msm_gpio_direction_input, >> .direction_output = msm_gpio_direction_output, >> .get_direction = msm_gpio_get_direction, >> -- >> 2.5.0 >> -- Gustavo A. R. Silva