Date: Wed, 12 Jul 2017 01:34:35 +0300
From: Yury Norov <ynorov@caviumnetworks.com>
To: David Howells <dhowells@redhat.com>
Cc: viro@zeniv.linux.org.uk, Latchesar Ionkov <lucho@ionkov.net>,
        Eric Van Hensbergen <ericvh@gmail.com>, linux-kernel@vger.kernel.org,
        v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
        Ron Minnich <rminnich@sandia.gov>
Subject: Re: [PATCH 12/14] 9p: Implement show_options
Message-ID: <20170711223435.x5tysl756jkrcrrt@yury-thinkpad>
References: <149926824154.20611.6104595541055328700.stgit@warthog.procyon.org.uk>
 <149926833746.20611.13052624709409745101.stgit@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <149926833746.20611.13052624709409745101.stgit@warthog.procyon.org.uk>
User-Agent: NeoMutt/20170113 (1.7.2)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2017 22:34:46.1576 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1864
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2298
Lines: 59

On Wed, Jul 05, 2017 at 04:25:37PM +0100, David Howells wrote:
> Implement the show_options superblock op for 9p as part of a bid to get
> rid of s_options and generic_show_options() to make it easier to implement
> a context-based mount where the mount options can be passed individually
> over a file descriptor.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Eric Van Hensbergen <ericvh@gmail.com>
> cc: Ron Minnich <rminnich@sandia.gov>
> cc: Latchesar Ionkov <lucho@ionkov.net>
> cc: v9fs-developer@lists.sourceforge.net
> ---

[...]

> +/*
> + * Display the mount options in /proc/mounts.
> + */
> +int v9fs_show_options(struct seq_file *m, struct dentry *root)
> +{
> +	struct v9fs_session_info *v9ses = root->d_sb->s_fs_info;
> +
> +	if (v9ses->debug)
> +		seq_printf(m, ",debug=%x", v9ses->debug);
> +	if (!uid_eq(v9ses->dfltuid, V9FS_DEFUID))
> +		seq_printf(m, ",dfltuid=%u",
> +			   from_kuid_munged(&init_user_ns, v9ses->dfltuid));
> +	if (!gid_eq(v9ses->dfltgid, V9FS_DEFGID))
> +		seq_printf(m, ",dfltgid=%u",
> +			   from_kgid_munged(&init_user_ns, v9ses->dfltgid));
> +	if (v9ses->afid != ~0)
> +		seq_printf(m, ",afid=%u", v9ses->afid);
> +	if (strcmp(v9ses->uname, V9FS_DEFUSER) != 0)
> +		seq_printf(m, ",uname=%s", v9ses->uname);
> +	if (strcmp(v9ses->aname, V9FS_DEFANAME) != 0)
> +		seq_printf(m, ",aname=%s", v9ses->aname);
> +	if (v9ses->nodev)
> +		seq_puts(m, ",nodevmap");
> +	if (v9ses->cache)
> +		seq_printf(m, ",%s", v9fs_cache_modes[v9ses->cache]);
> +	if (v9ses->cachetag && v9ses->cache == CACHE_FSCACHE)
> +		seq_printf(m, ",cachetag=%s", v9ses->cachetag);

Hi David, 

I just found that this patch breaks the next-20170711 build for me:
fs/9p/v9fs.c: In function ‘v9fs_show_options’:
fs/9p/v9fs.c:140:13: error: ‘struct v9fs_session_info’ has no member
named ‘cachetag’; did you mean ‘cache’?
  if (v9ses->cachetag && v9ses->cache == CACHE_FSCACHE)
               ^~~~~~~~
               cache
fs/9p/v9fs.c:141:40: error: ‘struct v9fs_session_info’ has no member named ‘cachetag’; did you mean ‘cache’?
   seq_printf(m, ",cachetag=%s", v9ses->cachetag);
                                        ^~~~~~~~
                                        cache
It seems you forgot to wrap it with #ifdef CONFIG_9P_FSCACHE

Yury