Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755911AbdGLAVL (ORCPT ); Tue, 11 Jul 2017 20:21:11 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:53385 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754135AbdGLAVK (ORCPT ); Tue, 11 Jul 2017 20:21:10 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1499776908-16811-1-git-send-email-mark.yao@rock-chips.com> <1499776958-17062-1-git-send-email-mark.yao@rock-chips.com> <7391489.lxuf2bMt0N@diego> Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <59656B6C.5020308@rock-chips.com> Date: Wed, 12 Jul 2017 08:21:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <7391489.lxuf2bMt0N@diego> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 51 On 2017年07月11日 20:45, Heiko Stübner wrote: > Hi Mark, > > Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao: >> Signed-off-by: Mark Yao >> --- >> Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 >> ++++ 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index >> 9eb3f0a..11fa3b0 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt >> @@ -8,8 +8,12 @@ Required properties: >> - compatible: value should be one of the following >> "rockchip,rk3036-vop"; >> "rockchip,rk3288-vop"; >> + "rockchip,rk3368-vop"; >> + "rockchip,rk3366-vop"; >> "rockchip,rk3399-vop-big"; >> "rockchip,rk3399-vop-lit"; >> + "rockchip,rk322x-vop"; > please don't use wildcards in devicetree compatibles. We've somehow > standardized on using rk3228 for both the rk3228 and rk3229 (which are > nearly the same soc with some speed adjustments) > > So, > + "rockchip,rk3228-vop"; > please > > > Thanks > Heiko Got it, I will fix it at next version Thanks Mark > >> + "rockchip,rk3328-vop"; >> >> - interrupts: should contain a list of all VOP IP block interrupts in the >> order: VSYNC, LCD_SYSTEM. The interrupt specifier > > > >