Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756072AbdGLBJ1 (ORCPT ); Tue, 11 Jul 2017 21:09:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39124 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755370AbdGLBJZ (ORCPT ); Tue, 11 Jul 2017 21:09:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2DE406044B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 11 Jul 2017 18:09:23 -0700 From: Stephen Boyd To: Suman Anna Cc: Rob Herring , Santosh Shilimkar , Tero Kristo , Nishanth Menon , Dave Gerlach , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: clock: ti-sci: Fix incorrect usage of headers Message-ID: <20170712010923.GP22780@codeaurora.org> References: <20170711223615.29398-1-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711223615.29398-1-s-anna@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2184 Lines: 50 On 07/11, Suman Anna wrote: > The clock consumer usage description was erroneously referring to > couple of dt-binding headers that are no longer valid. The definition > and/or usage of these headers is incorrect and the only file present > at the moment, dt-bindings/soc/k2g.h is also being cleaned up. The > examples in this binding were updated properly, but the update to > description was missed out. So, fix this. > > Fixes: 8f306cfe4383 ("Documentation: dt: Add TI SCI clock driver") > Signed-off-by: Suman Anna > --- > Hi Stephen, > > Looks like this was missed during the update/repost of the ti-sci-clk > driver/binding. FYI, Santosh is going to pickup the header file cleanup > patch https://patchwork.kernel.org/patch/9741279/ for the next merge > window. I'll let Rob apply this as it is purely a binding document update. > > regards > Suman > > Documentation/devicetree/bindings/clock/ti,sci-clk.txt | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/ti,sci-clk.txt b/Documentation/devicetree/bindings/clock/ti,sci-clk.txt > index 1e884c40ab50..4e59dc6b1778 100644 > --- a/Documentation/devicetree/bindings/clock/ti,sci-clk.txt > +++ b/Documentation/devicetree/bindings/clock/ti,sci-clk.txt > @@ -14,10 +14,9 @@ Required properties: > - compatible: Must be "ti,k2g-sci-clk" > - #clock-cells: Shall be 2. > In clock consumers, this cell represents the device ID and clock ID > - exposed by the PM firmware. The assignments can be found in the header > - files .h> (which covers the device IDs) and > - .h> (which covers the clock IDs), where > - is the SoC involved, for example 'k2g'. > + exposed by the PM firmware. The list of valid values for the device IDs > + and clocks IDs for 66AK2G SoC are documented at > + http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data > I hope the weblink doesn't die in the future. Why can't we copy it into the binding document here for safe keeping? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project