Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756125AbdGLCH4 (ORCPT ); Tue, 11 Jul 2017 22:07:56 -0400 Received: from mga04.intel.com ([192.55.52.120]:2197 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754999AbdGLCHz (ORCPT ); Tue, 11 Jul 2017 22:07:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,347,1496127600"; d="scan'208";a="285751126" Subject: Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods To: Christoph Lameter , Frederic Weisbecker Cc: Peter Zijlstra , Andi Kleen , Aubrey Li , tglx@linutronix.de, len.brown@intel.com, rjw@rjwysocki.net, tim.c.chen@linux.intel.com, arjan@linux.intel.com, paulmck@linux.vnet.ibm.com, yang.zhang.wz@gmail.com, x86@kernel.org, linux-kernel@vger.kernel.org References: <1499650721-5928-1-git-send-email-aubrey.li@intel.com> <20170710084647.zs6wkl3fumszd33g@hirez.programming.kicks-ass.net> <20170710144609.GD31832@tassilo.jf.intel.com> <20170710164206.5aon5kelbisxqyxq@hirez.programming.kicks-ass.net> <20170710172705.GA3441@tassilo.jf.intel.com> <20170711094157.5xcwkloxnjehieqv@hirez.programming.kicks-ass.net> <20170711160926.GA18805@lerouge> From: "Li, Aubrey" Message-ID: <5de2c77b-0c55-5fd9-64f6-aba67f111db5@linux.intel.com> Date: Wed, 12 Jul 2017 10:07:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 21 On 2017/7/12 1:58, Christoph Lameter wrote: > On Tue, 11 Jul 2017, Frederic Weisbecker wrote: > >>> --- a/kernel/time/tick-sched.c >>> +++ b/kernel/time/tick-sched.c >>> @@ -787,6 +787,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts, >>> if (!ts->tick_stopped) { >>> calc_load_nohz_start(); >>> cpu_load_update_nohz_start(); >>> + quiet_vmstat(); >> >> This patch seems to make sense. Christoph? > > Ok makes sense to me too. Was never entirely sure where the proper place > would be to call it. > Do we have another path to invoke tick_nohz_stop_sched_tick() in the interrupt exit context for nohz full case? Thanks, -Aubrey