Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756016AbdGLCTd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Jul 2017 22:19:33 -0400
Received: from szxga05-in.huawei.com ([45.249.212.191]:2097 "EHLO
        szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754675AbdGLCTc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Jul 2017 22:19:32 -0400
Subject: Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion
To: John Garry <john.garry@huawei.com>, <jejb@linux.vnet.ibm.com>,
        <martin.petersen@oracle.com>
References: <1499670369-44143-1-git-send-email-wangyijing@huawei.com>
 <1499670369-44143-3-git-send-email-wangyijing@huawei.com>
 <e76b392c-8fd7-9907-9a10-87b8c5b737dc@huawei.com>
CC: <chenqilin2@huawei.com>, <hare@suse.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <chenxiang66@hisilicon.com>,
        <huangdaode@hisilicon.com>, <wangkefeng.wang@huawei.com>,
        <zhaohongjiang@huawei.com>, <dingtianhong@huawei.com>,
        <guohanjun@huawei.com>, <yanaijie@huawei.com>, <hch@lst.de>,
        <dan.j.williams@intel.com>, <emilne@redhat.com>, <thenzl@redhat.com>,
        <wefu@redhat.com>, <charles.chenxin@huawei.com>,
        <chenweilong@huawei.com>, Linuxarm <linuxarm@huawei.com>
From: wangyijing <wangyijing@huawei.com>
Message-ID: <596586F7.80307@huawei.com>
Date: Wed, 12 Jul 2017 10:18:31 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <e76b392c-8fd7-9907-9a10-87b8c5b737dc@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.177.23.4]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A090204.59658728.0071,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 3ccd7f715fbd0a62d017cd30ded80660
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 919
Lines: 37



在 2017/7/11 23:54, John Garry 写道:
> On 10/07/2017 08:06, Yijing Wang wrote:
>> No one uses the port_gone_completion in struct asd_sas_port,
>> clean it out.
> 
> This seems like a reasonable tidy-up patch which could be taken in isolation, having no dependency on the rest of the series.

Yes.

> 
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>>  include/scsi/libsas.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
>> index c41328d..628f48b 100644
>> --- a/include/scsi/libsas.h
>> +++ b/include/scsi/libsas.h
>> @@ -263,8 +263,6 @@ struct sas_discovery {
>>  /* The port struct is Class:RW, driver:RO */
>>  struct asd_sas_port {
>>  /* private: */
>> -    struct completion port_gone_completion;
>> -
>>      struct sas_discovery disc;
>>      struct domain_device *port_dev;
>>      spinlock_t dev_list_lock;
>>
> 
> 
> 
> .
>