Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756586AbdGLCbp (ORCPT ); Tue, 11 Jul 2017 22:31:45 -0400 Received: from mga03.intel.com ([134.134.136.65]:51473 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754700AbdGLCbo (ORCPT ); Tue, 11 Jul 2017 22:31:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,347,1496127600"; d="scan'208";a="877812035" From: "Zhang, Tina" To: Daniel Vetter , Gerd Hoffmann CC: "Tian, Kevin" , "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "alex.williamson@redhat.com" , "zhenyuw@linux.intel.com" , "chris@chris-wilson.co.uk" , Kirti Wankhede , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" Subject: RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Topic: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Index: AQHS9d72/JOqiz5kqkOIoMWmOT5rIKJGTuYAgAdZDwCAADHdAIABpeDA Date: Wed, 12 Jul 2017 02:31:40 +0000 Message-ID: <237F54289DF84E4997F34151298ABEBC7C57BF86@SHSMSX101.ccr.corp.intel.com> References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com> <1499753648.8257.3.camel@redhat.com> <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> In-Reply-To: <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6C2VwR1024313 Content-Length: 2160 Lines: 55 > -----Original Message----- > From: intel-gvt-dev [mailto:intel-gvt-dev-bounces@lists.freedesktop.org] On > Behalf Of Daniel Vetter > Sent: Tuesday, July 11, 2017 5:13 PM > To: Gerd Hoffmann > Cc: Tian, Kevin ; linux-kernel@vger.kernel.org; intel- > gfx@lists.freedesktop.org; alex.williamson@redhat.com; > zhenyuw@linux.intel.com; chris@chris-wilson.co.uk; Kirti Wankhede > ; Lv, Zhiyuan ; > daniel@ffwll.ch; Zhang, Tina ; intel-gvt- > dev@lists.freedesktop.org; Wang, Zhi A > Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation > > On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > +struct vfio_device_query_gfx_plane { > > > > + __u32 argsz; > > > > + __u32 flags; > > > > + struct vfio_device_gfx_plane_info plane_info; > > > > + __u32 plane_type; > > > > + __s32 fd; /* dma-buf fd */ > > > > + __u32 plane_id; > > > > +}; > > > > + > > > > > > It would be better to have comment here about what are expected > > > values for plane_type and plane_id. > > > > plane_type is DRM_PLANE_TYPE_*. > > > > yes, a comment saying so would be good, same for drm_format which is > > DRM_FORMAT_*. While looking at these two: renaming plane_type to > > drm_plane_type (for consistency) is probably a good idea too. > > > > plane_id needs a specification. > > Why do you need plane_type? With universal planes the plane_id along is > sufficient to identify a plane on a given drm device instance. I'd just remove it. > -Daniel The plane_type here, is to ask the mdev vendor driver to return the information according to the value in field plane_type. So, it's a input field. The values in plane_type field is the same of drm_plane_type. And yes, it's better to use drm_plane_type instead of plane_id. Thanks. Tina > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > intel-gvt-dev mailing list > intel-gvt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev