Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932757AbdGLCnv (ORCPT ); Tue, 11 Jul 2017 22:43:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:58760 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932555AbdGLCnu (ORCPT ); Tue, 11 Jul 2017 22:43:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,347,1496127600"; d="scan'208";a="126030574" From: "Zhang, Tina" To: Gerd Hoffmann , "alex.williamson@redhat.com" , "chris@chris-wilson.co.uk" , "zhenyuw@linux.intel.com" , "Lv, Zhiyuan" , "Wang, Zhi A" , "Tian, Kevin" , "daniel@ffwll.ch" , "kwankhede@nvidia.com" CC: "intel-gfx@lists.freedesktop.org" , "intel-gvt-dev@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Topic: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Index: AQHS9d72/JOqiz5kqkOIoMWmOT5rIKJNpiqAgAHcaTA= Date: Wed, 12 Jul 2017 02:43:46 +0000 Message-ID: <237F54289DF84E4997F34151298ABEBC7C57BFA1@SHSMSX101.ccr.corp.intel.com> References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <1499753263.8257.1.camel@redhat.com> In-Reply-To: <1499753263.8257.1.camel@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6C2hvOv024619 Content-Length: 1932 Lines: 58 > -----Original Message----- > From: Gerd Hoffmann [mailto:kraxel@redhat.com] > Sent: Tuesday, July 11, 2017 2:08 PM > To: Zhang, Tina ; alex.williamson@redhat.com; > chris@chris-wilson.co.uk; zhenyuw@linux.intel.com; Lv, Zhiyuan > ; Wang, Zhi A ; Tian, Kevin > ; daniel@ffwll.ch; kwankhede@nvidia.com > Cc: intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation > > > +/** > > + * VFIO_DEVICE_QUERY_GFX_PLANE - _IOW(VFIO_TYPE, VFIO_BASE + 14, > > + *                           struct vfio_device_query_gfx_plane) > > + * Return: 0 on success, -errno on failure. > > + */ > > + > > +struct vfio_device_gfx_plane_info { > > + __u64 start; > > + __u64 drm_format_mod; > > + __u32 drm_format; > > + __u32 width; > > + __u32 height; > > + __u32 stride; > > + __u32 size; > > + __u32 x_pos; > > + __u32 y_pos; > > +}; > > Do we want keep that as separate struct? Given we now have only a single > struct using that as sub-struct it looks pointless, at least from a API point of view. > Does the driver use the struct internally? Driver has another struct which is super-set of these fields. Yes, we can move all these fields into struct vfio_device_query_gfx_plane. Also, we can remove some of these fields which may seem useless for user mode. Thanks. Tina > > > + > > +struct vfio_device_query_gfx_plane { > > + __u32 argsz; > > + __u32 flags; > > + struct vfio_device_gfx_plane_info plane_info; > > + __u32 plane_type; > > + __s32 fd; /* dma-buf fd */ > > + __u32 plane_id; > > What is plane_id? I cannot figure out the mean of plane_id either. If I remember correctly, it was asked by region usage. Of course, if no one needs it, I'd like to remove it. Thanks. Tina > > cheers, > Gerd