Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756127AbdGLDnu (ORCPT ); Tue, 11 Jul 2017 23:43:50 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17395 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbdGLDns (ORCPT ); Tue, 11 Jul 2017 23:43:48 -0400 Subject: Re: sun4v+DMA related boot crash on 4.13-git To: David Miller Cc: mroos@linux.ee, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org References: <60fa7a06-d319-9b6f-aba8-7b63014a1120@oracle.com> <20170711.173436.720922946430226024.davem@davemloft.net> From: Tushar Dave Message-ID: <94c3900e-781e-da0e-e1fe-ad1239ed8dee@oracle.com> Date: Tue, 11 Jul 2017 20:43:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170711.173436.720922946430226024.davem@davemloft.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2049 Lines: 56 On 07/11/2017 05:34 PM, David Miller wrote: > From: Tushar Dave > Date: Tue, 11 Jul 2017 15:38:21 -0700 > >> >> >> On 07/11/2017 02:48 PM, Meelis Roos wrote: >>>>>>>> I tested yesterdayd 4.12+git on sparc64 to see if the sparc merge >>>>>>>> works >>>>>>>> fine, and on all of my sun4v machines (T1000, T2000, T5120) it crashed >>>>>>>> on boot with DMA-related stacktrace (below). Allt he machines are >>>>>>>> sun4v >>>>>>>> physical machines, not VM-s. Older sun4 machines do not exhibit this >>>>>>>> problem. >>>>>>>> >>>>>>>> Maybae DMA APi realted, maybe sparc64. Will try to bisect when I get >>>>>>>> time. >>>>>>> I see whats going on with panic. I will reproduce locally. Will get >>>>>>> back >>>>>>> soon. >>>>>> This patch should fix panic. Please give it a try. >>>>> >>>>> Yes, this patch fixes it. Thank you for fixing it quickly! >>>> Thanks for testing. Patch sent for sparc-next. >>> Why sparc-next - it should go into 4.13 since 4.13 would break all >>> niagara1 and niagara2 systems otherwise?This is sparc arch fix so I >>> used sparc tree(in this case for sparc-next). >> I am open to maintainers suggestions. Thanks. > > If the bug is in Linus's tree the fix must target 'sparc' not > 'sparc-next'. Dave, Yes, indeed the bug is in Linus's tree. However, 'sparc' tree doesn't have DMA API change (e.g. commit b02c2b0bfd7ae) yet that introduced the panic. Looks like the DMA API changes have not merged into 'sparc' tree yet. In other words, 'sparc' tree doesn't have mentioned panic issue, nothing to fix there! However, 'sparc-next' is up to date (or more close to) linus tree and has DMA API change that cause mentioned panic issue. So I have send patch targeted for sparc-next. Let me know what should be the best tree to get this fix in and I will send v2. Thanks. -Tushar > -- > To unsubscribe from this list: send the line "unsubscribe sparclinux" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >