Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755585AbdGLFJS convert rfc822-to-8bit (ORCPT ); Wed, 12 Jul 2017 01:09:18 -0400 Received: from mga03.intel.com ([134.134.136.65]:2406 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbdGLFJR (ORCPT ); Wed, 12 Jul 2017 01:09:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,347,1496127600"; d="scan'208";a="124091090" From: "Dilger, Andreas" To: Greg Kroah-Hartman CC: "Drokin, Oleg" , James Simmons , Lustre Development List , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List Subject: Re: [PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h Thread-Topic: [PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h Thread-Index: AQHS9sLyM8LjHHm8G0iABs2aWlnIq6JPWjmAgADHqgA= Date: Wed, 12 Jul 2017 05:09:16 +0000 Message-ID: <80BA3F43-DFB0-45B2-A36A-83628E731A88@intel.com> References: <20170711171449.GC11838@kroah.com> In-Reply-To: <20170711171449.GC11838@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.99.110] Content-Type: text/plain; charset="us-ascii" Content-ID: <12B44F700E6F064FAD1D33CAE9D4BBB4@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1935 Lines: 56 On Jul 11, 2017, at 11:14, Greg Kroah-Hartman wrote: > > On Fri, Jul 07, 2017 at 01:47:04AM +0000, Craig Inches wrote: >> This fixes multiple block statements found not to match >> style as per checkpatch >> >> Signed-off-by: Craig Inches >> --- >> drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 +++++++++++++-------- >> 1 file changed, 81 insertions(+), 48 deletions(-) >> >> diff --git a/drivers/staging/lustre/include/linux/lnet/lnetst.h b/drivers/staging/lustre/include/linux/lnet/lnetst.h >> index ea736f8d5231..a4f9ff01d458 100644 >> --- a/drivers/staging/lustre/include/linux/lnet/lnetst.h >> +++ b/drivers/staging/lustre/include/linux/lnet/lnetst.h >> @@ -54,7 +54,8 @@ >> #define LSTIO_GROUP_ADD 0xC10 /* add group */ >> #define LSTIO_GROUP_LIST 0xC11 /* list all groups in session */ >> #define LSTIO_GROUP_INFO 0xC12 /* query default information of >> - * specified group */ >> + * specified group >> + */ >> #define LSTIO_GROUP_DEL 0xC13 /* delete group */ >> #define LSTIO_NODES_ADD 0xC14 /* add nodes to specified group */ >> #define LSTIO_GROUP_UPDATE 0xC15 /* update group */ >> @@ -102,27 +103,32 @@ struct lstcon_test_ent { >> int tse_type; /* test type */ >> int tse_loop; /* loop count */ >> int tse_concur; /* concurrency of test */ >> -}; /*** test summary entry, for >> - *** list_batch command */ >> +}; /* test summary entry, for >> + * list_batch command >> + */ > > That's odd, what was the *** stuff for? > > I'd like to get a lustre maintainer's ack for all of these before I > apply them... It's nothing that I know about. We used DOxygen to comment the code and generate docs, but the "***" isn't any markup that I'm familiar with. Reviewed-by: Andreas Dilger Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation