Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756043AbdGLFNP convert rfc822-to-8bit (ORCPT ); Wed, 12 Jul 2017 01:13:15 -0400 Received: from mga11.intel.com ([192.55.52.93]:35789 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdGLFNO (ORCPT ); Wed, 12 Jul 2017 01:13:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,347,1496127600"; d="scan'208";a="124092002" From: "Dilger, Andreas" To: Greg KH CC: Jaya Durga , "Drokin, Oleg" , "jsimmons@infradead.org" , "Hammond, John" , "bobijam@hotmail.com" , "mingo@kernel.org" , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro Thread-Topic: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro Thread-Index: AQHS9igPnaUXinN9NUu4zsIeNpWrBKJPWZ0AgADKlIA= Date: Wed, 12 Jul 2017 05:13:11 +0000 Message-ID: <326250A0-4785-40C4-BA11-2D708815039B@intel.com> References: <1499325195-17466-1-git-send-email-rjdurga@gmail.com> <20170711170818.GA5013@kroah.com> In-Reply-To: <20170711170818.GA5013@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.99.110] Content-Type: text/plain; charset="us-ascii" Content-ID: <35EBBFE87433E54D9D7A34FC1810912B@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 43 > On Jul 11, 2017, at 11:08, Greg KH wrote: > > On Thu, Jul 06, 2017 at 12:43:15PM +0530, Jaya Durga wrote: >> Replace all instances of (1 << 27) with BIT(27) to fix >> checkpatch check messages >> >> Signed-off-by: Jaya Durga >> --- >> drivers/staging/lustre/lustre/include/lustre_compat.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/lustre/lustre/include/lustre_compat.h b/drivers/staging/lustre/lustre/include/lustre_compat.h >> index da9ce19..686a251 100644 >> --- a/drivers/staging/lustre/lustre/include/lustre_compat.h >> +++ b/drivers/staging/lustre/lustre/include/lustre_compat.h >> @@ -43,7 +43,7 @@ >> * set ATTR_BLOCKS to a high value to avoid any risk of collision with other >> * ATTR_* attributes (see bug 13828) >> */ >> -#define ATTR_BLOCKS (1 << 27) >> +#define ATTR_BLOCKS BIT(27) > > Isn't this used in lustre's userspace code? If so, you can't use the > BIT() macro there :( > > Please check before you redo this. The "lustre_compat.h" header was previously used for compatibility between different kernel versions, which is why it is now basically empty. It isn't used for userspace interfaces as other "compat" headers are in the kernel. Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation