Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756598AbdGLFXu (ORCPT ); Wed, 12 Jul 2017 01:23:50 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:32858 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdGLFXs (ORCPT ); Wed, 12 Jul 2017 01:23:48 -0400 MIME-Version: 1.0 In-Reply-To: <20170712045114.21508-3-rjosephwright@gmail.com> References: <20170712045114.21508-1-rjosephwright@gmail.com> <20170712045114.21508-3-rjosephwright@gmail.com> From: Frans Klaver Date: Wed, 12 Jul 2017 07:23:47 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] Staging: android/ion: fix sparse warning To: Joseph Wright Cc: Greg KH , arve@android.com, riandrews@android.com, driverdevel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 39 Hi, Again, your subject is too generic. On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright wrote: > Declare private function static to fix sparse warning: > > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ > was not declared. Should it be static? > > Signed-off-by: Joseph Wright > --- > Changes in v2: > - Split into multiple patches > > drivers/staging/android/ion/ion_cma_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c > index a0949bc..c6db9b7 100644 > --- a/drivers/staging/android/ion/ion_cma_heap.c > +++ b/drivers/staging/android/ion/ion_cma_heap.c > @@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma) > return &cma_heap->heap; > } > > -int __ion_add_cma_heaps(struct cma *cma, void *data) > +static int __ion_add_cma_heaps(struct cma *cma, void *data) > { > struct ion_heap *heap; > > -- > 2.9.3 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel