Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756802AbdGLHGZ (ORCPT ); Wed, 12 Jul 2017 03:06:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:34752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdGLHGX (ORCPT ); Wed, 12 Jul 2017 03:06:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4020C22C9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Wed, 12 Jul 2017 15:06:11 +0800 From: Shawn Guo To: Oleksij Rempel Cc: Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] ARM: dts: imx6: RIoTboard provide gpio-line-names Message-ID: <20170712070609.GG3172@dragon> References: <20170620142830.5119-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620142830.5119-1-o.rempel@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2559 Lines: 92 On Tue, Jun 20, 2017 at 04:28:30PM +0200, Oleksij Rempel wrote: > for each gpio controller Please write up a complete sentence. If you can explain a bit why these names are useful would be better. > > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-riotboard.dts | 61 ++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts > index 2cb72824e800..b9ecb3b3792a 100644 > --- a/arch/arm/boot/dts/imx6dl-riotboard.dts > +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts > @@ -84,6 +84,67 @@ > }; > }; > > +&gpio1 { > + gpio-line-names = > + "", "", "[SD2_WP]", "", "[SD2_CD]", "I2C3_SCL", > + "I2C3_SDA", "I2C4_SCL", > + "I2C4_SDA", "", "", "", "", "", "", "", > + "", "PWM3", "", "", "", "", "", "", > + "", "", "", "", "", "", "", ""; > +}; > + > +&gpio2 { > + gpio-line-names = > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", ""; > +}; > + > +&gpio3 { > + gpio-line-names = > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "[USB_OTG_VBUS]", "", > + "UART3_TXD", "UART3_RXD", "", "", "[EIM_D28]", "", "", ""; > +}; > + > +&gpio4 { > + gpio-line-names = > + "", "", "", "", "", "", "UART4_TXD", "UART4_RXD", > + "UART5_TXD", "UART5_RXD", "", "", "", "", "", "", > + "GPIO4_16", "GPIO4_17", "GPIO4_18", "GPIO4_19", "", > + "CSPI3_CLK", "CSPI3_MOSI", "CSPI3_MISO", > + "CSPI3_CS0", "CSPI3_CS1", "GPIO4_26", "GPIO4_27", > + "CSPI3_RDY", "PWM1", "PWM2", "GPIO4_31"; > +}; > + > +&gpio5 { > + gpio-line-names = > + "", "", "[EIM_A25]", "", "", "GPIO5_05", "GPIO5_06", > + "GPIO5_07", > + "GPIO5_08", "CSPI2_CS1", "CSPI2_MOSI", "CSPI2_MISO", > + "CSPI2_CS0", "CSPI2_CLK", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", ""; > +}; > + > +&gpio6 { > + gpio-line-names = > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", ""; > +}; > + > +&gpio7 { > + gpio-line-names = > + "[SD3_CD]", "[SD3_WP]", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "", ""; > +}; > + > &audmux { Please keep the new added nodes sorted alphabetically in label name. Shawn > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_audmux>; > -- > 2.11.0 >