Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756815AbdGLHQO (ORCPT ); Wed, 12 Jul 2017 03:16:14 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35431 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdGLHQN (ORCPT ); Wed, 12 Jul 2017 03:16:13 -0400 MIME-Version: 1.0 In-Reply-To: References: <1493380030-4683-1-git-send-email-mark.rutland@arm.com> <20170523100446.GB14542@leverpostej> From: Ganapatrao Kulkarni Date: Wed, 12 Jul 2017 12:46:11 +0530 Message-ID: Subject: Re: [PATCH 0/2] perf stat: fix segfault when closing events To: Mark Rutland , acme@kernel.org, alexander.shishkin@linux.intel.com, Ingo Molnar Cc: "linux-kernel@vger.kernel.org" , "ganapatrao.kulkarni@cavium.com" , Jayachandran C , gpkulkarni Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1796 Lines: 59 The perf tool segmentation fault which we were observing and this patch series intended to fix it, has been fixed due to change in default behaviour of perf stat[1][2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.12&id=0d79f8b93187c771b6971acfaba67f4e2f1e0710 [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-4.11.y&id=0d79f8b93187c771b6971acfaba67f4e2f1e0710 On Fri, Jun 9, 2017 at 10:03 AM, Ganapatrao Kulkarni wrote: > ping? > > On Tue, May 23, 2017 at 8:44 PM, Ganapatrao Kulkarni > wrote: >> On Tue, May 23, 2017 at 3:34 PM, Mark Rutland wrote: >>> Hi, >>> >>> Does anyone have any comments on these? >>> >>> I'm happy to rebase/resend if necessary. >>> >>> I'd very much like to see this fixed. >> >> arm64 platforms have dependency on this patch set to use latest perf tool. >> Earliest merge/review is much appreciated!! >> >>> >>> Thanks, >>> Mark. >>> >>> On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: >>>> Hi, >>>> >>>> These patches fix a segfault seen in some cases when perf stat is exiting. >>>> >>>> We don't balance opening/closing of events in all cases, and go out-of-bounds >>>> when we close events. Full details in the patch 2 commit message. >>>> >>>> Thanks, >>>> Mark. >>>> >>>> Mark Rutland (2): >>>> perf evsel: add per{cpu,thread} close helpers >>>> perf stat: balance opening/closing of events >>>> >>>> tools/perf/builtin-stat.c | 24 +++++++++++++++++++++++- >>>> tools/perf/util/evsel.c | 26 ++++++++++++++++++++------ >>>> tools/perf/util/evsel.h | 4 ++++ >>>> 3 files changed, 47 insertions(+), 7 deletions(-) >>>> >>>> -- >>>> 1.9.1 >>>> >> >> thanks >> Ganapat thanks Ganapat